RFR: 8303485: Replacing os.name for operating system customization

David Holmes dholmes at openjdk.org
Fri Mar 10 05:45:13 UTC 2023


On Fri, 10 Mar 2023 05:09:49 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> Don't we have a conditional compilation ability with these template files such that we can just generate true or false depending on the OS?
>
> Good point.  `OperatingSystemProps.java` can be a OS-specific class like: 
> 
> src/java.base/macosx/classes/jdk/internal/misc/OperatingSystemProps.java
>               linux/classes/jdk/internal/misc/OperatingSystemProps.java
>               windows/classes/jdk/internal/misc/OperatingSystemProps.java
> 
> 
> OTOH, if we include `os.arch`, that would need to be a template.   A single template file to include both OS and ARCH would do it.

I was literally thinking of the `#if[xx]` conditional compilation facility rather than an OS specific file, but okay ...

-------------

PR: https://git.openjdk.org/jdk/pull/12931



More information about the build-dev mailing list