RFR: JDK-8301998: Update HarfBuzz to 7.0.1 [v2]
Phil Race
prr at openjdk.org
Mon Mar 13 23:54:00 UTC 2023
On Thu, 9 Mar 2023 06:12:26 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> HarfBuzz library updated from v4.4.1 to v7.0.1
>>
>> - harfbuzz.md file updated
>> - Added -DHB_NO_VISIBILITY to HARFBUZZ_CFLAGS in Awt2DLibraries.gmk to avoid build issues on linux and macos targets.
>> - GPOS.hh moved to Layout to Layout/GPOS to match upstream changes.
>> - hb-ot-color-* files moved to OT/Color to match upstream changes.
>> - 41 newly added, 8 deleted and 224 modified files (src + harfbuzz.md).
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> Updating.txt changes
src/java.desktop/share/native/libharfbuzz/hb.hh line 107:
> 105: #pragma GCC diagnostic warning "-Wformat=2"
> 106: #pragma GCC diagnostic warning "-Wformat-signedness"
> 107: #pragma GCC diagnostic warning "-Wignored-pragma-optimize"
Reading these changes makes me think we should re-check if all the DISABLED_WARNINGS we have for
harbuzz in Awt2DLibraries.gmk (see lines 466-470 in that file) are still needed.
In particular for gcc + clang (ie windows and mac builds).
Can you comment them out (in that file) and test the build ? Any that are now un-needed can be removed.
-------------
PR: https://git.openjdk.org/jdk/pull/12913
More information about the build-dev
mailing list