RFR: JDK-8304537: Ant-based langtools build fails after JDK-8015831 Add lint check for calling overridable methods from a constructor

Archie L. Cobbs duke at openjdk.org
Mon Mar 20 15:13:31 UTC 2023


On Mon, 20 Mar 2023 14:50:01 GMT, Jan Lahoda <jlahoda at openjdk.org> wrote:

> `this-escape` lint is disabled for jdk.compiler, so it should be disabled for the ant-based langtools-only build as well.

Just a note... the fix for JDK-8304443 adds `@SuppressWarnings("this-escape")` to the compiler code, and that should also fix this bug as a side effect. This PR, which disables the `this-escape` lint warning, works too, of course.

So, just in case you change your mind and choose to NOT disable the `this-escape` lint warning, then for consistency's sake we should also re-enable it for the regular build in `modules/jdk.compiler/Gendata.gmk` and `modules/jdk.compiler/Java.gmk`.

My apologies for using two different approaches to suppressing the warning at different times.

-------------

PR: https://git.openjdk.org/jdk/pull/13102



More information about the build-dev mailing list