RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview)

[Paul Sandoz]

On Fri, 17 Mar 2023 15:42:56 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> API changes for the FFM API (third preview)
> 
> Specdiff:
> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
> 
> Javadoc:
> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html

src/java.base/share/classes/java/lang/foreign/Linker.java line 609:

> 607:          * @see #captureStateLayout()
> 608:          */
> 609:         static Option captureCallState(String... capturedState) {

What if a name is not recognized? Throw IAE?

src/java.base/share/classes/java/lang/foreign/Linker.java line 621:

> 619:          *          to a downcall handle linked with {@link #captureCallState(String...)}}
> 620:          *
> 621:          * @see #captureCallState(String...)

How does a caller know what the structure may contain? Should we document the platform specific structures?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1142804110
PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1142804836