RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v5]

Per Minborg pminborg at openjdk.org
Tue Mar 21 12:02:44 UTC 2023


On Tue, 21 Mar 2023 09:54:16 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> I've added an example of how to print the platform-dependent structure. Should we document anyhow?
>
> I'm not sure about this. Honestly, the example probably doesn't help much if somebody didn't get the idea of what the layout might be. I think it might be better to say something like, `on Windows/x64 the returned layout might be as follows...` and then you write the code to create the layout instance corresponding to the returned layout. But we have to be careful to make the text non-normative (as the set of values might change).

What about adding something like this?


Here is a list of valid names for some platforms:
    Linux:
        "errno"
    macOS:
        "errno"
    Windows:
        "GetLastError", "WSAGetLastError" and "errno"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1143265595



More information about the build-dev mailing list