RFR: 8304265: Implementation of Foreign Function and Memory API (Third Preview) [v5]

[Jorn Vernee]

On Tue, 21 Mar 2023 09:02:29 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> API changes for the FFM API (third preview)
>> 
>> Specdiff:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/specdiff/overview-summary.html
>> 
>> Javadoc:
>> https://cr.openjdk.org/~pminborg/panama/21/v1/javadoc/java.base/module-summary.html
>
> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add example for Option::captureStateLayout

src/java.base/share/classes/java/lang/foreign/Arena.java line 59:

> 57:  * which features a <em>bounded lifetime</em> that is managed, automatically, by the garbage collector. As such, the regions
> 58:  * of memory backing memory segments allocated with the automatic arena are deallocated at some unspecified time
> 59:  * <em>after</em> the automatic allocator (and all the segments allocated by it) become

Suggestion:

 * <em>after</em> the automatic arena (and all the segments allocated by it) become

src/java.base/share/classes/java/lang/foreign/Arena.java line 89:

> 87:  * Memory segments allocated with a {@linkplain #ofConfined() confined arena} can only be accessed (and closed) by the
> 88:  * thread that created the arena. If access to a memory segment from multiple threads is required, clients can allocate
> 89:  * segment in a {@linkplain #ofShared() shared arena} instead.

Suggestion:

 * segments in a {@linkplain #ofShared() shared arena} instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1143734059
PR Review Comment: https://git.openjdk.org/jdk/pull/13079#discussion_r1143738342