RFR: 8303229: JFR: Preserve disk repository after exit [v5]

David Holmes dholmes at openjdk.org
Thu Mar 23 22:10:49 UTC 2023


On Thu, 23 Mar 2023 13:49:42 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi,
>> 
>> Could I have a review of an enhancement that adds the option preserve-repository=true/false to -XX:FlightRecorderOptions and jcmd JFR.configure. When set to true, chunk files in the repository will not be removed by the JVM at exit.
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Typo

src/jdk.jcmd/share/man/jcmd.1 line 409:

> 407: after the JVM has exited.
> 408: If false, files are deleted.
> 409: By default, this parameters is disabled.

This still has "parameters" typo.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13111#discussion_r1146926863



More information about the build-dev mailing list