RFR: 8303485: Replacing os.name for operating system customization [v6]
Michael Osipov
duke at openjdk.org
Fri Mar 24 16:07:29 UTC 2023
On Fri, 24 Mar 2023 00:27:42 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Improvements to support OS specific customization for JDK internal use:
>> - To select values and code; allowing elimination of unused code and values
>> - Optionally evaluated by build processes, compilation, or archiving (i.e. CDS)
>> - Simple API to replace adhoc comparisons with `os.name`
>> - Clear and consistent use across build, runtime, and JDK modules
>>
>> The PR includes updates within java.base to use the new API.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename OperatingSystem enum values to uppercase
@battleblow FYI
src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 66:
> 64:
> 65: /**
> 66: * The Linux Operating system.
For the sake if completeness, Linux isn't an operating system, so this statement isn't correct.
src/java.base/share/classes/jdk/internal/util/OperatingSystem.java line 81:
> 79: */
> 80: AIX,
> 81: ;
So no Unknown value?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/12931#issuecomment-1483049583
PR Review Comment: https://git.openjdk.org/jdk/pull/12931#discussion_r1147785316
PR Review Comment: https://git.openjdk.org/jdk/pull/12931#discussion_r1147784804
More information about the build-dev
mailing list