RFR: 8304871: Use default visibility for static library builds [v2]

[Severin Gehwolf]

On Mon, 27 Mar 2023 08:56:15 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> make/autoconf/flags-cflags.m4 line 639:
>> 
>>> 637:   STATIC_LIBS_CFLAGS="-DSTATIC_BUILD=1"
>>> 638:   if test "x$TOOLCHAIN_TYPE" = xgcc || test "x$TOOLCHAIN_TYPE" = xclang; then
>>> 639:     STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS -ffunction-sections -fdata-sections"
>> 
>> Is it better/clearer to make the use of the default explicit as we do in the source:
>> 
>> #define JNIEXPORT     __attribute__((visibility("default")))
>> 
>> ?
>
> @dholmes-ora Do you mean something like this (instead of removing the `-D` expression)?
> 
> 
> STATIC_LIBS_CFLAGS="$STATIC_LIBS_CFLAGS -ffunction-sections -fdata-sections \
>       -DJNIEXPORT='__attribute__((visibility("default")))'"
> 
> 
> I can surely do that if that's preferred. No preference either way as far as I'm concerned.

I've done that now. Let me know if that's what you had in mind.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13177#discussion_r1149050621