RFR: 8304871: Use default visibility for static library builds [v2]
David Holmes
dholmes at openjdk.org
Tue Mar 28 04:43:28 UTC 2023
On Mon, 27 Mar 2023 09:40:22 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Please review this change for symbol visibility of static library artefacts. This fixes an issue when
>> OpenJDK is being used as a base for generating native images preventing the symbols from being
>> exported and looked up from the executable. Note that symbol visibity is now controlled by a
>> linker version script downstream. This changes nothing for the regularly shipped dynamic libraries.
>>
>> Thoughts?
>
> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>
> Explicitly set the JNI_EXPORT define for static libs
I also added this to JBS:
JDK-8239563 was also done to support Graal, and this change is now undoing that. Do the Graal folk who want this understand it will restore the problem that JDK-8239563 fixed?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13177#issuecomment-1486205397
More information about the build-dev
mailing list