RFR: 8304893: Link Time Optimization with gcc can be faster [v2]
Erik Joelsson
erikj at openjdk.org
Wed Mar 29 13:35:59 UTC 2023
On Mon, 27 Mar 2023 05:47:28 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Comment not required
>
> make/hotspot/lib/JvmFeatures.gmk line 173:
>
>> 171: ifeq ($(call isCompiler, gcc), true)
>> 172: JVM_CFLAGS_FEATURES += -flto=$(JOBS) -fuse-linker-plugin -fno-strict-aliasing -fno-fat-lto-objects
>> 173: JVM_LDFLAGS_FEATURES += -O3 -flto=$(JOBS) -fuse-linker-plugin -fno-strict-aliasing
>
> Shouldn't the `-O3` be using the `OPTIMIZATION` level in case it has been overridden from `HIGHEST_JVM`?
It may make sense to have the `-O*` argument to the linker match what we do for compilation. I'm not sure how related they are.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13180#discussion_r1151951546
More information about the build-dev
mailing list