RFR: JDK-8305118: Add RISC-V related content to building.md [v2]
Guoxiong Li
gli at openjdk.org
Thu Mar 30 04:12:03 UTC 2023
On Wed, 29 Mar 2023 13:37:36 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Guoxiong Li has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - Add riscv64 related content to 'Debian sysroots'
>> - qemu-debootstrap has been deprecated, use debootstrap instead.
>> - Fix typos and adjust text width.
>
> doc/building.md line 1233:
>
>> 1231: The RISC-V community provides a basic [GNU compiler toolchain](https://github.com/riscv-collab/riscv-gnu-toolchain).
>> 1232: But the [external libraries](#External-Library-Requirements) required by OpenJDK complicate the building process.
>> 1233: The placeholder `<toolchain-installed-path>` shown below is the path you want to install the toolchain.
>
> Please keep paragraph text to 80 character width.
>
> "is the path you want" -> "is the path where you want"
Fixed.
> doc/building.md line 1246:
>
>> 1244: * Cross-compile all the required libraries:
>> 1245: ```
>> 1246: # An example about libffi
>
> Suggestion:
>
> # An example for libffi
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13223#discussion_r1152707845
PR Review Comment: https://git.openjdk.org/jdk/pull/13223#discussion_r1152707831
More information about the build-dev
mailing list