RFR: JDK-8305118: Add RISC-V related content to building.md [v2]
Chen Liang
liach at openjdk.org
Thu Mar 30 04:25:15 UTC 2023
On Thu, 30 Mar 2023 04:11:58 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Hi all,
>>
>> This patch adds the RISC-V related content to `building.md`. But I didn't
>> generate `building.html` locally, because I know the `pandoc` version
>> may influencethe the output of `building.html` (Need help here).
>>
>> I know there are many steps and subtle points about cross-compiling the
>> external libraries. Considering the content length and the libraries are
>> introduced at `External Library Requirements`, I give only one example
>> instead of all of them.
>>
>> And I tried to build it by using `devkits` and `Debian sysroots`. But it failed locally.
>> Maybe someone who has built successfully can tell me how to change the
>> document, which mainly adds the right name to their supported target table.
>>
>> Thanks for the review and assist.
>>
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with three additional commits since the last revision:
>
> - Add riscv64 related content to 'Debian sysroots'
> - qemu-debootstrap has been deprecated, use debootstrap instead.
> - Fix typos and adjust text width.
doc/building.md line 1237:
> 1235: The RISC-V community provides a basic
> 1236: [GNU compiler toolchain](https://github.com/riscv-collab/riscv-gnu-toolchain).
> 1237: But the [external libraries](#External-Library-Requirements) required by OpenJDK
Suggestion:
However, the [external libraries](#External-Library-Requirements) required by OpenJDK
or change 'But' to ', but'
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13223#discussion_r1152714869
More information about the build-dev
mailing list