RFR: 8304295: VM build fails with GCC 7 after JDK-8301998

Fri Mar 31 04:49:14 UTC 2023

On Thu, 30 Mar 2023 21:31:07 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> > If we will going forward with this patch, can we exclude the warning for the old compilers only? as was mentioned in the JBS the gcc10+ compiles that code fine.
> 
> The build system doesn't have a convenient way of selectively disable warnings for different compiler versions. I recommend against trying to implement that here.
> 
> If this library is all third-party code, does it really matter that much if we disable another warning? We aren't responsible for keeping this source warning free as we can't make changes to it to anyway.

Isnt it is possible to check the TOOLCHAIN_TYPE+TOOLCHAIN_VERSION as we did here?:
https://github.com/openjdk/jdk/commit/347672464127a5d4dd847ba2a4ca30c5ff51b32c
Or we do not set such props for gcc?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13253#issuecomment-1491281764