RFR: JDK-8306112 Implementation of JEP 445: Flexible Main Methods and Anonymous Main Classes (Preview) [v2]
Jim Laskey
jlaskey at openjdk.org
Mon May 1 12:10:55 UTC 2023
On Thu, 27 Apr 2023 18:00:38 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:
>> src/java.base/share/native/libjli/java.c line 590:
>>
>>> 588: CHECK_EXCEPTION_NULL_LEAVE(mainID);
>>> 589: (*env)->CallVoidMethod(env, mainObject, mainID);
>>> 590: break;
>>
>> This calls into LauncherHelper to get the "main type", then calls the static or new/instance method. I'm wondering if you tried have a single entry point in LauncherHelper instead. I think the only downside might be that the trampoline would show up in stack traces but @Hidden could hide that.
>
> Good idea. If @hidden doesn't work then we can eat the trace entries.
Many dependencies (ex. JDI) on main being the first frame. Will set up a separate RFE witch should include using the LauncherHelper in the source code launcher.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13689#discussion_r1181532559
More information about the build-dev
mailing list