RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

Fri May 5 14:38:19 UTC 2023

On Thu, 4 May 2023 19:52:22 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Alexander Zvegintsev has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - update, based on review comments
>>  - remove wayland detection
>>  - BUILD_LIBPIPEWIRE_HEADER_DIRS -> LIBPIPEWIRE_HEADER_DIRS
>
> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 194:
> 
>> 192:     LIBAWT_XAWT_EXCLUDES := medialib debug
>> 193: 
>> 194:     BUILD_LIBPIPEWIRE_HEADER_DIRS := \
> 
> This variable name indicates that LIBPIPEWIRE is a library that we would build, but it seems to just be headers. I would suggest dropping the `BUILD_` prefix.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13803#discussion_r1186173916