RFR: 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots [v2]

[Maxim Kartashev]

On Fri, 5 May 2023 14:26:49 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

> P.S. I removed synchronized modifier from getRGBPixels
My main point was that you don't seem to need to have both, and while I picked one you picked the other ;-) So it's OK.

>> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 50:
>> 
>>> 48: jmethodID storeTokenMethodID = NULL;
>>> 49: 
>>> 50: inline void debug_screencast(
>> 
>> Does this one need to be externally visible? If not, it can be (also) made `static`.
>
> It is used by `screencast_portal.c` and `screencast_pipewire.c`.

OK, then it actually does need to be externally visible. Thanks!

>> src/java.desktop/unix/native/libawt_xawt/awt/screencast_pipewire.c line 789:
>> 
>>> 787:                             env, pixelArray,
>>> 788:                             start, len,
>>> 789:                             ((jint *) screenProps->captureData)
>> 
>> I'm not sure if endianness of `captureData` matches the expected endianness of `pixelArray`.
>
> For now, it is going to be supported on x86-64 only, but it is a good candidate for investigation.

Is this enforced somehow? I mean what happens if this code is built on risc-v or arm?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13803#discussion_r1186179577
PR Review Comment: https://git.openjdk.org/jdk/pull/13803#discussion_r1186180467
PR Review Comment: https://git.openjdk.org/jdk/pull/13803#discussion_r1186184024