RFR: 8307527: MacOS Zero builds fail with undefined FFI_GO_CLOSURES after JDK-8304265 [v2]
Erik Joelsson
erikj at openjdk.org
Mon May 8 13:52:25 UTC 2023
On Mon, 8 May 2023 10:18:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> See the bug. Actually, I am not sure why JDK-8304265 changed the `#ifndef FFI_GO_CLOSURES` to `#ifdef _APPLE_`. That seems too intrusive if `FFI_GO_CLOSURES` *is* enabled. So I rewrote the block to something more safe.
>>
>> Additional testing:
>> - [x] macos-aarch64-zero-fastdebug `make images` passes
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Use a build system fix
Marked as reviewed by erikj (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/13827#pullrequestreview-1416842813
More information about the build-dev
mailing list