RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

Chen Liang liach at openjdk.org
Mon May 8 20:05:50 UTC 2023


> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. The root cause might be that JMH requires passing VM args to benchmarks in quotes, which might have triggered incorrect detections in `FIXPATH` (as in comparison, `$1_MICRO_JAVA_OPTIONS += --add-opens=java.base/java.io=ALL-UNNAMED` right above this patch seems to work fine)
> Also removed a useless and wrong Java flag to the java running javac, originally intended to enable running `make test TEST="loom.obsolete"` benchmarks.
> 
> Since I only have a windows cygwin environment, I am not quite sure if this works elsewhere.

Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Comment about the fix logic
   We have a mix and match of spaces and tabs, might need to fix it later
 - Is this the right way instead?
 - space fails linux
 - Expose fixpath import and let jmh run use it
 - Merge branch 'master' into jmh-windows
 - 8305669: RuntimeException when running benchmarks through make on Windows/WSL

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13550/files
  - new: https://git.openjdk.org/jdk/pull/13550/files/11df4e9c..0866ee3c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13550&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13550&range=00-01

  Stats: 80515 lines in 1424 files changed: 55854 ins; 14773 del; 9888 mod
  Patch: https://git.openjdk.org/jdk/pull/13550.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13550/head:pull/13550

PR: https://git.openjdk.org/jdk/pull/13550



More information about the build-dev mailing list