RFR: 8305669: RuntimeException when running benchmarks through make on Windows/WSL [v2]

[Erik Joelsson]

On Mon, 8 May 2023 20:05:50 GMT, Chen Liang <liach at openjdk.org> wrote:

>> This patch replaces `FIXPATH` with `FixPath` on individual path argumenets. The root cause might be that JMH requires passing VM args to benchmarks in quotes, which might have triggered incorrect detections in `FIXPATH` (as in comparison, `$1_MICRO_JAVA_OPTIONS += --add-opens=java.base/java.io=ALL-UNNAMED` right above this patch seems to work fine)
>> Also removed a useless and wrong Java flag to the java running javac, originally intended to enable running `make test TEST="loom.obsolete"` benchmarks.
>> 
>> Since I only have a windows cygwin environment, I am not quite sure if this works elsewhere.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Comment about the fix logic
>    We have a mix and match of spaces and tabs, might need to fix it later
>  - Is this the right way instead?
>  - space fails linux
>  - Expose fixpath import and let jmh run use it
>  - Merge branch 'master' into jmh-windows
>  - 8305669: RuntimeException when running benchmarks through make on Windows/WSL

> Per Claes [#13671 (comment)](https://github.com/openjdk/jdk/pull/13671#discussion_r1188840349) we should move the open and export additions to the individual tests instead of adding them during building of the microbenchmark suite. I will wait for others opinions before deciding the way to go.

If there is a way to supply them in the tests themselves (similar to how we do for jtreg tests), then I agree that is a better idea than adding them globally for the whole test run.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13550#issuecomment-1540575605