RFR: JDK-8306983: Do not invoke external programs when switch terminal to raw mode on selected platforms [v3]

[Jan Lahoda]

On Thu, 11 May 2023 15:15:02 GMT, Vicente Romero <vromero at openjdk.org> wrote:

>> Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reflecting review feedback.
>
> src/jdk.internal.le/linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/CLibrary.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2002-2020, the original author or authors.
> 
> 2023 only?

This is the original header from JLine, which we generally keep.

> src/jdk.internal.le/linux/classes/jdk/internal/org/jline/terminal/impl/jna/linux/CLibrary.java line 16:
> 
>> 14: import java.util.List;
>> 15: 
>> 16: //import com.sun.jna.LastErrorException;
> 
> there is a lot of commented code in this file, not sure if it has a purpose or just left overs?

I've intentionally left the original JLine code commented here and on other places, to see what the code was doing originally, and to possibly aid future merges of new versions of JLine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13687#discussion_r1191427112
PR Review Comment: https://git.openjdk.org/jdk/pull/13687#discussion_r1191428160