RFR: 8300204: Sealed-class hierarchy graph missing nodes
Jonathan Gibbons
jjg at openjdk.org
Fri May 12 21:03:56 UTC 2023
On Tue, 9 May 2023 06:35:03 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> Please review this simple patch that fixes the package determination for nested classes in the `@sealedGraph` taglet.
>>
>> Current JDK 21:
>> https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/lang/foreign/MemoryLayout.html
>> https://download.java.net/java/early_access/jdk21/docs/api/java.base/java/lang/foreign/ValueLayout.html
>> 
>>
>> This patch:
>> https://cr.openjdk.org/~liach/8300204/java.base/java/lang/foreign/MemoryLayout.html
>> https://cr.openjdk.org/~liach/8300204/java.base/java/lang/foreign/ValueLayout.html
>> 
>
> Looks good to me! Thanks for providing this patch. Unfortunately, I am not a reviewer so we have to get someone else to review it.
I'll sponsor this, given the comment by @minborg
https://github.com/openjdk/jdk/pull/13875#issuecomment-1539537777
> Looks good to me! Thanks for providing this patch. Unfortunately, I am not a reviewer so we have to get someone else to review it.
@minborg You may not be an OpenJDK "R"eviewer yet, but you can still "review" changes and report whether you approve the changes.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13875#issuecomment-1546291445
PR Comment: https://git.openjdk.org/jdk/pull/13875#issuecomment-1546296142
More information about the build-dev
mailing list