RFR: 8307652: sealed class hierarchy graph doesn't distinguish non-sealed classes

Jonathan Gibbons jjg at openjdk.org
Fri May 12 22:09:47 UTC 2023


On Tue, 9 May 2023 04:11:03 GMT, Chen Liang <liach at openjdk.org> wrote:

> `@sealedGraph` had a mechanism to render non-sealed classes differently, but it's useless because the graph nodes are not bordered. This patch converts the non-sealed classes to be rendered in italics instead.
> 
> An example of `ConstantDesc`, which has a sealed hierarchy except `DynamicConstantDesc`:
> JDK 20:
> ![image](https://user-images.githubusercontent.com/7806504/236991678-e30c181a-cb1f-407a-b3e0-f648fe2df788.png)
> 
> This patch:
> ![image](https://user-images.githubusercontent.com/7806504/236991592-affcb128-9721-45cf-860c-6292ee6a8bb6.png)

@minborg You should comment on this one.   

I'm not sure that italics by itself is a good idea.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13877#issuecomment-1546361261



More information about the build-dev mailing list