RFR: 8307855: update for deprecated sprintf for src/utils [v2]
Xue-Lei Andrew Fan
xuelei at openjdk.org
Mon May 15 06:15:56 UTC 2023
On Sun, 14 May 2023 00:43:51 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Xue-Lei Andrew Fan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> update typo in copyright statement
>
> src/utils/hsdis/binutils/hsdis-binutils.c line 222:
>
>> 220: const decode_func_stype decode_func_address = &decode_instructions;
>> 221:
>> 222: #define remaining_buflen(buf, bufsize, p) ((bufsize) - ((p) - (buf)))
>
> This shouldn't be a macro. Among other reasons, see the style guide.
May I have an reference to the style guide?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13915#discussion_r1193366077
More information about the build-dev
mailing list