RFR: JDK-8306304: Fix xlc17 clang warnings in ppc and aix code [v2]

[JoKern65]

On Fri, 12 May 2023 22:01:46 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> JoKern65 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cosmetic changes
>
> src/java.desktop/aix/native/libawt/porting_aix.c line 49:
> 
>> 47:   for (;;) {
>> 48:     if (addr >= p->ldinfo_textorg &&
>> 49:         (char*)addr < (char*)(p->ldinfo_textorg) + p->ldinfo_textsize) {
> 
> What is being warned about here?  At worst, could you just cast the RHS to `void*`?

/porting_aix.c:49:34: error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wgnu-pointer-arith]
        addr < p->ldinfo_textorg + p->ldinfo_textsize) {

and with` void*` cast on RHS
porting_aix.c:49:43: error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wgnu-pointer-arith]
        addr < (void*)(p->ldinfo_textorg) + p->ldinfo_textsize) {

So either my code change or disabling warning gnu-pointer-arith. What would you prefer? and if you prefer disabling the Warning, where should I do it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13953#discussion_r1193594350