RFR: 8308071: [REDO] update for deprecated sprintf for src/utils [v3]
Xue-Lei Andrew Fan
xuelei at openjdk.org
Thu May 18 17:50:41 UTC 2023
On Thu, 18 May 2023 15:46:46 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Updated to use `int` to replace `size_t.`. Thank you for the catching.
>
> bufsize is size_t, so that's a comparison between signed and unsigned values, which I think some compilers
> will warn about. Maybe the preceding check for negative is getting rid of that? But will that still occur in
> a slowdebug build, or will the lack of optimization lead to a warning?
As always, this comment helps a lot. Thank you!
Updated to cast `int` to `size_t` explicitly.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13995#discussion_r1198111051
More information about the build-dev
mailing list