RFR: 8308341: JNI_GetCreatedJavaVMs returns a partially initialized JVM
Gerard Ziemski
gziemski at openjdk.org
Fri May 26 17:53:58 UTC 2023
On Thu, 25 May 2023 05:02:19 GMT, David Holmes <dholmes at openjdk.org> wrote:
> We now track the in-progress and completed states of VM creation and only return a VM from JNI_GetCreatedJavaVMs when there is a fully initialized VM.
>
> Testing:
> - new regression test
> - tiers 1-3 (sanity)
>
> Thanks
Looks fine to me.
I have one question though: why wouldn't it be enough to move `vm_created = 1` from where we had it before, down to where we now have `vm_created = COMPLETE` ?
I'm not 100% sure why we need the intermediate step `IN_PROGRESS`
-------------
PR Review: https://git.openjdk.org/jdk/pull/14139#pullrequestreview-1446696175
More information about the build-dev
mailing list