RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

Robbin Ehn rehn at openjdk.org
Wed Nov 1 11:52:20 UTC 2023


> Hi, please consider.
> 
> insn_options[0] is set to empty string if there is no options (NULL or empty strings).
> Checking it for empty string should cover both cases, caller option is NULL or caller option is empty string.
> 
> Tested hsdis no longer gives me the warning.

Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:

  More clear

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/16433/files
  - new: https://git.openjdk.org/jdk/pull/16433/files/58eb19b1..94ccd7f9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16433&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16433&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16433.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16433/head:pull/16433

PR: https://git.openjdk.org/jdk/pull/16433


More information about the build-dev mailing list