RFR: 8319165: hsdis binutils: warns on empty string as option string [v2]

[Robbin Ehn]

On Thu, 2 Nov 2023 09:22:55 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More clear
>
> src/utils/hsdis/binutils/hsdis-binutils.c line 341:
> 
>> 339:                                  /* On some archs we get warnings, if we pass empty options */
>> 340:                                  ((caller_options == NULL) || (app_data->insn_options[0] == '\0'))
>> 341:                                  ? NULL : app_data->insn_options);
> 
> Suggestion:
> 
>                                  ((caller_options == NULL) || (app_data->insn_options[0] == '\0'))
>                                    ? NULL : app_data->insn_options);

Applied

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16433#discussion_r1379988717