RFR: 8319570: Change to GCC 13.2.0 for building on Linux at Oracle [v2]

Mikael Vidstedt mikael at openjdk.org
Wed Nov 8 22:16:59 UTC 2023


On Wed, 8 Nov 2023 21:30:24 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> FWIW I just followed the preexisting pattern in the same file, e.g. https://github.com/openjdk/jdk/blob/7d25f1c6cb770e21cfad8096c1637a24e65fab8c/make/hotspot/lib/CompileJvm.gmk#L1100. @magicus Let me know if you want me to change it.
>
>> [T]he And macro was actually added by you
> 
> Oh. 😊 Ohh... That was a bit stupid of me, then. :) But I just checked, I found 4 cases of `$(call And)` vs 11 cases of using `+` in our makefiles. So it is a clear overweight for the `+` syntax, but is not the sole pattern as I thought.
> 
> So yes, it is okay to keep it as it is.

Leaving it as-is then. Thank you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16550#discussion_r1387257535


More information about the build-dev mailing list