RFR: 8320053: GHA: Cross-compile gtest code

Magnus Ihse Bursie ihse at openjdk.org
Tue Nov 14 10:57:29 UTC 2023


On Tue, 14 Nov 2023 10:06:00 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Looking at why GHA did not catch [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it builds hotspot, I realized we do not configure the build with gtest, which means we skip the build checks for gtest VM. It would be useful to cross-compile with all tests enabled, even without running them.
> 
> (This would probably make sense to do for JDK native code, but AFAICS it would require defining a few new make targets).
> 
> Additional testing:
>  - [ ] GHA

Have you tested this? I can't see how this possibly could work. You'd need a 


      - name: 'Get GTest'
        id: gtest
        uses: ./.github/actions/get-gtest


section to have a `steps.gtest` to refer to.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16652#issuecomment-1809981291


More information about the build-dev mailing list