RFR: 8320053: GHA: Cross-compile gtest code [v2]

Tue Nov 14 11:10:31 UTC 2023

On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Looking at why GHA did not catch [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it builds hotspot, I realized we do not configure the build with gtest, which means we skip the build checks for gtest VM. It would be useful to cross-compile with all tests enabled, even without running them.
>> 
>> (This would probably make sense to do for JDK native code, but AFAICS it would require defining a few new make targets).
>> 
>> Additional testing:
>>  - [ ] GHA
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also get gtest

Looks good, but make sure it is run properly through GHA before integrating.

(If you feel the urge to open a PR before all testing is complete, you can mark it as draft to avoid having it being reviewed before it is ready to review...)

-------------

Marked as reviewed by ihse (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16652#pullrequestreview-1729498131
PR Comment: https://git.openjdk.org/jdk/pull/16652#issuecomment-1809999435