RFR: 8320053: GHA: Cross-compile gtest code [v2]

[Aleksey Shipilev]

On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Looking at why GHA did not catch [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it builds hotspot, I realized we do not configure the build with gtest, which means we skip the build checks for gtest VM. It would be useful to cross-compile with all tests enabled, even without running them.
>> 
>> (This would probably make sense to do for JDK native code, but AFAICS it would require defining a few new make targets).
>> 
>> Additional testing:
>>  - [ ] GHA
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Also get gtest

The cross-builds are fine in GHA. I don't see build time regressions, they are the similar to baseline build times, given the normally large variation. gtest vm compiles significantly fewer files, so the impact on build times _should be_ low:


Creating support/modules_libs/java.base/server/libjvm.so from 1217 file(s)
Creating hotspot/variant-server/libjvm/libgtest/libgtest.a from 2 file(s)
Creating hotspot/variant-server/libjvm/gtest/libjvm.so from 192 file(s)
Creating hotspot/variant-server/libjvm/gtest/gtestLauncher from 1 file(s)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16652#issuecomment-1810161178