RFR: 8320053: GHA: Cross-compile gtest code [v2]
Magnus Ihse Bursie
ihse at openjdk.org
Wed Nov 15 12:42:33 UTC 2023
On Tue, 14 Nov 2023 11:04:43 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Looking at why GHA did not catch [JDK-8320050](https://bugs.openjdk.org/browse/JDK-8320050), even though it builds hotspot, I realized we do not configure the build with gtest, which means we skip the build checks for gtest VM. It would be useful to cross-compile with all tests enabled, even without running them.
>>
>> (This would probably make sense to do for JDK native code, but AFAICS it would require defining a few new make targets).
>>
>> Additional testing:
>> - [x] GHA
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>
> Also get gtest
I think you can proceed with just my review, yes. GHA does not get much attention so you're not likely to get many other reviews. And this patch is fairly trivial.
-------------
Marked as reviewed by ihse (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16652#pullrequestreview-1731945429
More information about the build-dev
mailing list