RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v3]
Xiaohong Gong
xgong at openjdk.org
Thu Nov 16 07:29:36 UTC 2023
On Thu, 16 Nov 2023 05:33:13 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Xiaohong Gong has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Add a bundled native lib in jdk as a bridge to libsleef
>> - Merge 'jdk:master' into JDK-8312425
>> - Disable sleef by default
>> - Merge 'jdk:master' into JDK-8312425
>> - 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF
>
> So to be clear, now you have to opt-in to using `libsleef` by building a binary that will use it. That binary will always use `libsleef` if found, so there is no way to opt-out at runtime. Is that the way it works on x86_64 too?
Thanks for adding the labels @dholmes-ora !
> So to be clear, now you have to opt-in to using libsleef by building a binary that will use it. That binary will always use libsleef if found, so there is no way to opt-out at runtime. Is that the way it works on x86_64 too?
Yes, libsleef is used to build the binary if found. And at runtime, if the libsleef with right version is not found, `dlopen` to the libvmath.so will fail. And then all the operations will be fall-back to the java default implementation. X86_64 has also bundled the Intel's SVML binary to jdk image at build time. And we use the same way loading/opening the library at runtime.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16234#issuecomment-1813916971
More information about the build-dev
mailing list