RFR: 8264425: Update building.md on non-English locales on Windows

Erik Joelsson erikj at openjdk.org
Thu Nov 16 17:07:35 UTC 2023


On Thu, 16 Nov 2023 16:41:05 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> Update the build documentation to reflect the fact that non-English locales are only supported on a "best effort" principle, and add instructions how to install the necessary language pack to Visual Studio.

doc/building.md line 207:

> 205: the building and testing to work on other locales as well. This is on a "best
> 206: effort" level, so beware! You might get odd results in both building and
> 207: testing. If you do, remember that any other locale than US English are not

Either change `are` -> `is`, or I think even better use suggestion below.
Suggestion:

testing. If you do, remember that locales other than US English are not

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16694#discussion_r1396057843


More information about the build-dev mailing list