RFR: 8264425: Update building.md on non-English locales on Windows [v3]
Naoto Sato
naoto at openjdk.org
Mon Nov 20 18:15:35 UTC 2023
On Mon, 20 Nov 2023 15:08:22 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Update the build documentation to reflect the fact that non-English locales are only supported on a "best effort" principle, and add instructions how to install the necessary language pack to Visual Studio.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>
> * Add requirement on system locale as well.
> * Reorganize text to be more logical
> * Emphasize that the US locale should be used
Thanks for the changes @magicus. This version looks very good in terms of the Windows locale environment.
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16694#pullrequestreview-1740416567
More information about the build-dev
mailing list