RFR: 8320358: GHA: ignore jdk* branches

Aleksey Shipilev shade at openjdk.org
Tue Nov 21 15:32:06 UTC 2023


On Tue, 21 Nov 2023 15:13:52 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> ... or the bots should name the branches `backport-${username}-${hash}` instead ..?

Yes, but the fact I can come up with an _easy_ example where it breaks serves as signal there are _likely_ less obvious broken cases :)

> I think it would be good to reserve the entire namespace beginning with `jdk`, to reserve for future use e.g. a `jdk-next` or whatever.

True.

> Also, we need to look at this where it is being used. I'm not sure that the `on: push: branches-ignore:` syntax allows for complex regexp syntax. Deeming from the example already present, it does not look like a regexp.

The [docs](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet) imply it is a variant of glob, which means either `jdk([0-9])+*` or `jdk+([0-9])*` [might work](https://www.digitalocean.com/community/tools/glob?comments=true&glob=jdk%2B%28%5B0-9%5D%29%2A&matches=false&tests=jdk&tests=jdk21&tests=jdk21u&tests=jdk21u-dev&tests=jdkusername-backport-12cafeebabe11&tests=jdk-8000000-fix).

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16763#issuecomment-1821143850


More information about the build-dev mailing list