RFR: 8320358: GHA: ignore jdk* branches

Kevin Rushforth kcr at openjdk.org
Tue Nov 21 16:02:07 UTC 2023


On Tue, 21 Nov 2023 14:42:07 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> At some point we are likely to use stabilization branches in the mainline jdk repo rather than a separate repo. In preparation, this PR excludes branches matching `jdk*`, like we currently do for `master` and `pr/*`.
> 
> A potential drawback of doing this is that it will exclude developer branches named `jdk-8888888` or similar, using a lower-case `jdk`. Developers who want a GHA run will need to use `JDK` (uppercase) or some other prefix.
> 
> This is unlikely to be a problem in practice. I checked the most recent 100 open pull requests in the `jdk` repo at the time I created this fix, and while many of them use "JDK" (upper case) as a prefix, I found none that use "jdk" (lower case).
> 
> 
> #### Testing
> 
> I pushed the following branch that was even with `jdk:master` at the time I pushed it (thus without this fix). GHA was run as expected:
> 
> * [jdk-8000000](https://github.com/kevinrushforth/jdk/tree/jdk-8000000) : [GHA run](https://github.com/kevinrushforth/jdk/actions/runs/6910232226) (NOTE: once this fix is integrated, such a branch would not get a GHA run)
> 
> 
> I pushed the following branches that all include this fix. GHA runs were skipped on the branches that start with `jdk` and run on the others:
> 
> * [JDK-8320358](https://github.com/kevinrushforth/jdk/tree/JDK-8320358) : [GHA run](https://github.com/kevinrushforth/jdk/actions/runs/6910192534), (you can also see this from this PR's test results)
> * [gha-exclude-jdk](https://github.com/kevinrushforth/jdk/tree/gha-exclude-jdk) : [GHA run](https://github.com/kevinrushforth/jdk/actions/runs/6910204060)
> * [jdk12345](https://github.com/kevinrushforth/jdk/tree/jdk12345) : No GHA run
> * [jdk-8320358-gha](https://github.com/kevinrushforth/jdk/tree/jdk-8320358-gha) : No GHA run

We are _very_ likely to use the name `jdkNN` matching the current name of the stabilization repos, and matching the practice in other repos such as jdk21u and jfx, so `jdk[0-9]*` should work for that based on my reading of the GHA docs.

As Magnus says, we might want to leave the door open in the future for `jdk-something-else`, which is why I proposed the simpler `jdk*`. However, that's an interesting point about it excluding a username that begins with `jdk` given how the bot creates the branch name for the `/backport` command.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16763#issuecomment-1821202770


More information about the build-dev mailing list