RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v6]

[Martin Doerr]

On Tue, 21 Nov 2023 17:49:43 GMT, suchismith1993 <duke at openjdk.org> wrote:

>> The math library in AIX specifically, is a static archive. Doing a -lm wont suffice, because when the symbols are looked up using dlsym or accessing native code through Java, it will lead to failures.
>> Hence we had to come up with a list of symbols to allow math library symbols to be accesible.
>> Also, there are parts of libc library that are static too, and hence those symbols also are present in this list.
>> Without this change, the StdLibTest and multiple other tests which make native function calls using FFI, fail with NoSuchElementException.
>> 
>> 
>> 1. Adding required compiler flags.
>> 2. Adding required symbols.
>> 
>> 
>> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
>
> suchismith1993 has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Comments
>  - Change comments

src/java.base/aix/native/libsyslookup/syslookup.c line 30:

> 28: #include <stdio.h>
> 29: #include <string.h>
> 30: #include <stdlib.h>

Are string.h and stdlib.h needed? I can't see them in the comments below.

src/java.base/aix/native/libsyslookup/syslookup.c line 33:

> 31: #include <math.h>
> 32: 
> 33: // Addresses of functions to referenced using static linking.

What does "functions to referenced" mean? Typo?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16414#discussion_r1400959365
PR Review Comment: https://git.openjdk.org/jdk/pull/16414#discussion_r1400961995