RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]

[suchismith1993]

On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 <duke at openjdk.org> wrote:

>> The math library in AIX specifically, is a static archive. Doing a -lm wont suffice, because when the symbols are looked up using dlsym or accessing native code through Java, it will lead to failures.
>> Hence we had to come up with a list of symbols to allow math library symbols to be accesible.
>> Also, there are parts of libc library that are static too, and hence those symbols also are present in this list.
>> Without this change, the StdLibTest and multiple other tests which make native function calls using FFI, fail with NoSuchElementException.
>> 
>> 
>> 1. Adding required compiler flags.
>> 2. Adding required symbols.
>> 
>> 
>> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
>
> suchismith1993 has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix Typos
>  - Remove unnecessary includes

Yes.The test cases for lookup of symbols have passed.
I think the bexpfull option helps in exporting the right symbols being
referenced.


On Wednesday, November 22, 2023, Jorn Vernee ***@***.***>
wrote:

> Note that on Windows we also have a lookup mechanism on the Java side:
> https://github.com/openjdk/jdk/blob/2c31ca525b1cd70c3dfcb0463c8c98
> 4bdd7c886a/src/java.base/share/classes/jdk/internal/
> foreign/SystemLookup.java#L159
>
> On Windows we need to load the global array, and then grab functions from
> the array. Why isn't that needed on AIX? Is dlsym able to find the
> statically linked functions as well?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk/pull/16414#issuecomment-1822205442>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AESW3BAJPWKB5I7MM7IVQKDYFWOCTAVCNFSM6AAAAAA6VZ2E4KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRSGIYDKNBUGI>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16414#issuecomment-1822243041