RFR: JDK-8317799 : AIX PPC64: FFI symbol lookup doesn't find symbols [v7]
Amit Kumar
amitkumar at openjdk.org
Wed Nov 22 13:30:16 UTC 2023
On Tue, 21 Nov 2023 19:30:30 GMT, suchismith1993 <duke at openjdk.org> wrote:
>> The math library in AIX specifically, is a static archive. Doing a -lm wont suffice, because when the symbols are looked up using dlsym or accessing native code through Java, it will lead to failures.
>> Hence we had to come up with a list of symbols to allow math library symbols to be accesible.
>> Also, there are parts of libc library that are static too, and hence those symbols also are present in this list.
>> Without this change, the StdLibTest and multiple other tests which make native function calls using FFI, fail with NoSuchElementException.
>>
>>
>> 1. Adding required compiler flags.
>> 2. Adding required symbols.
>>
>>
>> JBS-ISSUE : [JDK-8317799](https://bugs.openjdk.org/browse/JDK-8317799)
>
> suchismith1993 has updated the pull request incrementally with two additional commits since the last revision:
>
> - Fix Typos
> - Remove unnecessary includes
src/java.base/aix/native/libsyslookup/syslookup.c line 3:
> 1: /*
> 2: * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
> 3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
Suggestion:
* Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2023, IBM Corp.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16414#discussion_r1402047735
More information about the build-dev
mailing list