RFR: 8306055: Add a built-in Catalog to JDK XML module [v3]

Joe Wang joehw at openjdk.org
Wed Nov 22 17:09:09 UTC 2023


On Wed, 22 Nov 2023 08:08:39 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Joe Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add a note; fix alignment
>
> test/jaxp/javax/xml/jaxp/unittest/common/catalog/CatalogTestBase.java line 299:
> 
>> 297:         Properties config, Properties[] sysProp, Properties[] apiProp, CustomCatalog cc,
>> 298:         boolean expectError, String error) throws Exception {
>> 299:         testSchema1(filename, xsd, fsp, state, config, sysProp, apiProp, cc, expectError,  error);
> 
> Suggestion:
> 
>         testSchema1(filename, xsd, fsp, state, config, sysProp, apiProp, cc, expectError, error);

Thanks. Fixed whitespace.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16719#discussion_r1402418756


More information about the build-dev mailing list