RFR: 8320515: assert(monitor->object_peek() != nullptr) failed: Owned monitors should not have a dead object [v2]

Stefan Karlsson stefank at openjdk.org
Thu Nov 23 11:45:00 UTC 2023


On Thu, 23 Nov 2023 02:10:41 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Tweaked comment in test
>>  - Rewrite tests
>
> test/hotspot/jtreg/runtime/Monitor/libIterateMonitorWithDeadObjectTest.c line 43:
> 
>> 41: static jobject create_object(JNIEnv* env) {
>> 42:   jclass clazz = (*env)->FindClass(env, "java/lang/Object");
>> 43:   if (clazz == 0) die("No class");
> 
> The `die` method is for errors with system calls. It won't show useful information for JNI calls that leave exceptions pending.

I've added better checks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16783#discussion_r1403263549


More information about the build-dev mailing list