RFR: 8295795: hsdis does not build with binutils 2.39+ [v8]

Robbin Ehn rehn at openjdk.org
Thu Nov 23 13:58:21 UTC 2023


On Thu, 23 Nov 2023 13:42:22 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> I don't know why.
>> 
>> 
>> [rehn at rehn-xps ~]$ cat m.c
>> int main() {
>>   void foo() {
>>     return;
>>   };
>>   foo();
>>   return 0;
>> }
>> [rehn at rehn-xps ~]$ gcc -Wall -Wextra -std=c89 m.c 
>> [rehn at rehn-xps ~]$
>
> @robehn I think that is a gcc extension; not ANSI C.

Yea, you are correct. Apparently the gcc extension is not turned off even if you use -ansi.
clang on the other hand complains.

@galderz your suggested patch is correct, can you open PR ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15138#discussion_r1403420418


More information about the build-dev mailing list