RFR: 8320763: Fix spacing arround assignment in spec.gmk.in [v2]

Erik Joelsson erikj at openjdk.org
Mon Nov 27 17:35:19 UTC 2023


On Mon, 27 Nov 2023 15:05:20 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> For some reason, we have not been consistent with using spaces around the assignment operators (`:=` and `=`) in spec.gmk.in. This has annoyed me for a long time.
>> 
>> When making this change, I noticed that there are a lot of late evaluation assignments (= instead of :=) that should not be there. To not confuse the code review, I will fix these separately. Thus this change will only change whitespace.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix ?=

Marked as reviewed by erikj (Reviewer).

> When making this change, I noticed that there are a lot of late evaluation assignments (= instead of :=) that should not be there.

Just be sure to not change those that are on purpose. At least some of them are interacting with the bootcycle and buildjdk spec files.

-------------

PR Review: https://git.openjdk.org/jdk/pull/16825#pullrequestreview-1750989012
PR Comment: https://git.openjdk.org/jdk/pull/16825#issuecomment-1828302345


More information about the build-dev mailing list