RFR: 8320533: Adjust capstone integration for v6 changes [v3]

[Galder Zamarreño]

On Mon, 27 Nov 2023 20:04:54 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>>> What's the issue with this? Full name on my profile "Galder Zamarreño". 
>> 
>> I don't know really. Could be a bug with the Skara bots that choke on the ñ (but I think we've had users with accented characters in their username before, so it should not be an issue). 
>> 
>> This is just a warning, not an integration blocker. If you think the HEAD author name looks fine, then you don't need to do anything. If you see this repeatedly (which might indicate a bug in Skara), you can report this on skara-dev at openjdk.org.
>
>> What's the issue with this? Full name on my profile "Galder Zamarreño".
> 
> I've dug into this a bit and here is what I've found. The letter [`ñ`](https://www.compart.com/en/unicode/U+00F1#:~:text=%E2%80%9C%C3%B1%E2%80%9D%20U%2B00F1%20Latin,N%20with%20Tilde%20Unicode%20Character) seems to have been encoded in two different ways in the GitHub user object and in the commit. Internally in the Skara bot, we get the GitHub user full name field returned as an 8 bit String where the characters is encoded as 0xF1. In the commit data from GitHub, the author field is encoded as a 16 bit String where the character is encoded as the composite of 006E and 0303. When we do a String.equals on these strings, it returns false. I can't say if that is correct but that is what's happening. If the 16 bit string was 00F1 it would have been fine.
> 
> Since you have an OpenJDK user, I would recommend that you [associate your GitHub account with your OpenJDK username](https://wiki.openjdk.org/display/SKARA/Skara#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername). This will avoid this check in the future.

Thanks a lot @erikj79 for looking into it. I've created the task to associate my username.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16788#issuecomment-1829260014