RFR: 8319577: x86_64 AVX2 intrinsics for Arrays.sort methods (int, float arrays) [v2]

Jatin Bhateja jbhateja at openjdk.org
Tue Nov 28 13:14:15 UTC 2023


On Tue, 28 Nov 2023 12:23:12 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>> 
>>  - Disable AVX2 sort for 64-bit types
>>  - Merge branch 'master' of https://git.openjdk.java.net/jdk into simdsort
>>  - fix jcheck failures due to windows encoding
>>  - fix carriage return and change insertion sort thresholds
>>  - fix formatting and white spaces
>>  - cleanup unused code
>>  - fix insertion sort thresholds
>>  - add insertion sort
>>  - fix headers
>>  - revert to xss-common-qsort
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/a21d12ff...08307b6a
>
> src/hotspot/share/opto/library_call.cpp line 5448:
> 
>> 5446:   BasicType bt = elem_type->basic_type();
>> 5447:   // Disable the intrinsic for 64-bit types with AVX2
>> 5448:   if ((bt == T_LONG || bt == T_DOUBLE) && UseAVX == 2) {
> 
> Same as above.

You can move this entire check to platform specific matcher file (matcher_x86.hpp)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16534#discussion_r1407681744


More information about the build-dev mailing list