RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v4]

Xiaohong Gong xgong at openjdk.org
Thu Nov 30 07:54:11 UTC 2023


On Thu, 23 Nov 2023 14:05:51 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Xiaohong Gong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments in build system
>
> make/autoconf/lib-vmath.m4 line 70:
> 
>> 68:         if test "x$SYSROOT" = "x" &&
>> 69:            test "x${LIBSLEEF_FOUND}" = "xno"; then
>> 70:           PKG_CHECK_MODULES([LIBSLEEF], [sleef], [LIBSLEEF_FOUND=yes], [LIBSLEEF_FOUND=no])
> 
> Suggestion:
> 
>           PKG_CHECK_MODULES([SLEEF], [sleef], [LIBSLEEF_FOUND=yes], [LIBSLEEF_FOUND=no])
> 
> 
> Otherwise `PKG_CHECK_MODULES` will set the variables  LIBSLEEF_CFLAGS and LIBSLEEF_LIBS.

Keep using `LIBSLEEF`, as the cflags and libs are named with `LIBSLEEF_` prefix. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16234#discussion_r1410275161


More information about the build-dev mailing list