RFR: 8316893: Compile without -fno-delete-null-pointer-checks [v3]

Erik Joelsson erikj at openjdk.org
Mon Oct 2 13:46:15 UTC 2023


On Mon, 2 Oct 2023 11:04:13 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Please review this patch that reenables `delete-null-pointer-checks` optimization in GCC and Clang.
>> 
>> It also disables `nonnull-compare` warning that is now triggered in debug builds. The problematic code will be addressed by #15927.
>> 
>> Mach5 Tier1-5 testing clean.
>
> Daniel Jeliński has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Restore quotes
>  - Remove no longer needed warning suppressions
>  - Merge remote-tracking branch 'origin' into delete-nullpointer
>  - Fix typo
>  - Disable nonull-compare warnings
>  - Remove -fno-delete-null-pointer-checks

Marked as reviewed by erikj (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15982#pullrequestreview-1652781399


More information about the build-dev mailing list